search

psifidotos / nowdock-plasmoid

Plasma 5 plasmoid that creates a plank or mac style effect for tasks
GNU General Public License v3.0
37 stars 3 forks source link

Branch svgs: Some icons have a thick black border #36

Closed alexjp closed 7 years ago

alexjp commented 7 years ago

Hi,

Its weird, but happening only in the svgs branch, some icons have a thick black border in them.

See -> Image

Icons: Hangouts and Tweetdeck ( Reddit is also a little weird )

Thanks !

psifidotos commented 7 years ago

if you have enabled shadows maybe it is an issue with them... Can you check again the latest commit in svgs for this? Does it get any better?

notice: the reddit icon is a wrong shadow issue for the hangouts and tweetdeck what should I observe???? I dont see the black border...

alexjp commented 7 years ago

See for example Image as to how hangouts and tweetdeck look like. It doesnt have that black border.

I will test with latest commit

alexjp commented 7 years ago

checked latest commit, doesn't fix it.

Also, i don't have shadows enabled while testing this.

alexjp commented 7 years ago

This video catches the problem: https://youtu.be/xlpqgfi48dM

alexjp commented 7 years ago

Basicly changing between size 48x48 and 128x128 versions of the hangouts icon

psifidotos commented 7 years ago

very strange... dont you think?

psifidotos commented 7 years ago

can you send alex the icon 128px. that creates the issue? even though I think that this is very strange...

alexjp commented 7 years ago

Yes, very strange. More info:

I rebooted computer and issue seemed gone ! Then i reenabled shadows and the issue appeared again. Then i disabled them again, and it was gone again.

alexjp commented 7 years ago

you can check out the icons in: https://we.tl/m6NomeI37R

I even put there all the icons i have locally ( not part of system )

psifidotos commented 7 years ago

yes... that is normal.... the latest commits in svgs branches were fixing this issue for disabling the shadows

what you are seeing is the shadow buffer... Unfortunately for that specific icon can not be drawn correctly ... And I dont know why.... Can you send me the problematic icon to play with it?

alexjp commented 7 years ago

Can you send me the problematic icon to play with it?

You have in the previous link both hangout icon and tweetdeck icon.

psifidotos commented 7 years ago

alex, in my system it happened only once when i changed the icon to the 128px. version manually... After that there is no issue... Especially if I trigger the launcher... Can you try to remove all alternative sizes for this icon and keep only the 128px one?

psifidotos commented 7 years ago

ok ... I fixed it in [svgs] branch .... I used an IconChanged signal to update the shadow buffers... this should always have correct shadow...

psifidotos commented 7 years ago

ok!! merged svgs to master !!!

@alexjp first thing to merge your branch!!! Debug a little !! And then we ready to launch 0.3 !!! :)

alexjp commented 7 years ago

Sorry ... was busy, wasnt following this.

Nice !!! I will merge master and my changes and test. Until now I didn't found any problem, but who knows.