search

psifidotos / workflow-project

This is an effort to create a KDE Plasmoid that integrates the main Activities, Virtual Desktops and Tasks Functionalities from Plasma Desktop in just one component.
http://workflow.opentoolsandspace.org/
GNU General Public License v2.0
11 stars 2 forks source link

Make use of the official tooltips component #58

Closed mdaffin closed 11 years ago

mdaffin commented 11 years ago

It would be better to make use of the official tooltips component rather then reimplementing it your self. This will decrease the amount of code you need to maintain and make the tooltips behave like the reset of the tooltips in plasma.

psifidotos commented 11 years ago

I agree.... DTooltip class will be removed. For the icons that are not official in the plasma theme there will be only Text version and no icon

mdaffin commented 11 years ago

That commit removes DToolTip completely, but there is still a bit of work in cleaning up the tooltips. I think some instances of the tooltips can be simplified such as in the activity header.

psifidotos commented 11 years ago

Michael I have accepted it in tempsync branch... I made some changes in order to fix issues in ActivityDeleg and WorkareaDeleg for tooltips... BIG Changes actually ... :) I cleaned up DTextLine and DTextEdit a lot, one small issue only remains in them, for some reason if the tooltip's target is whole component of DTextLine or DTextEdit the containsMouse in them is not working... The workaround is to assign to the target explicitly one of the MouseAreas in them. To make that happen I use a property called tooltipItem in them.

Before these commits I cleaned up also TaskPreviewDeleg, a very big task but one adds value to their maintenance... It was split in three classes, BasicTaskDeleg which is standalone, TaskPreviewDeleg which is standalone and ScrolledTaskPreview which uses as much functionality as possible from TaskPreviewDeleg (ScrolledTaskPreview class supports scrolling of previews in the Desktops Dialog when windows are more than 9)

mdaffin commented 11 years ago

This feature has not yet been merged into the master branch, it would be best to only close an issue once it is solved in the master branch (preferably via a commit message). This allows you to better track the status of the master branch and not lose issues in other branches.