psifidotos / workflow-project

This is an effort to create a KDE Plasmoid that integrates the main Activities, Virtual Desktops and Tasks Functionalities from Plasma Desktop in just one component.
http://workflow.opentoolsandspace.org/
GNU General Public License v2.0
11 stars 2 forks source link

WorkFlow widget takes up extra space in panel #72

Open mikevaughn83 opened 11 years ago

mikevaughn83 commented 11 years ago

snapshot3 Since upgrading to 0.3.0, the WorkFlow widget takes up a very wide area in the panel, as seen in the attached screenshot (all of the blank space between the pager and the system tray is occupied by WorkFlow). I was able to reproduce the problem under a clean ~/.kde, but oddly, it didn't occur until I removed the default taskbar widget.

psifidotos commented 11 years ago

Mike I can not reproduce it, what kde and distro do u use? in the image you sent WorkFlow is the house icon ? So you use WorkFlow with setting use the current activity icon? The three circles next to house icon is the indicator for activities? (BTW Nice icon :) )

mikevaughn83 commented 11 years ago

I'm using KDE 4.10 on Kubuntu 12.10. Correct, WorkFlow is the house icon and the three cirles icon is the indicator. I'm using WorkFlow with that setting, however, the problem persists using WorkFlow's default settings. By the way, here's the icon theme I'm using: http://kde-look.org/content/show.php/Potenza?content=155481 (but the problem still occurs using the default Oxygen icon theme).

psifidotos commented 11 years ago

ok... I will test it in virtual box to see if I can reproduce it... It is probably kde4.10 which I dont use yet...

psifidotos commented 11 years ago

Well mike, I use Kubuntu 12.10 and KDE 4.10 in a VirtualBox and I can not reproduce... Try the following, add a second panel with default settings, add WorkFlow in that panel and tell me step by step how to reproduce the problem... Adding, removing the default taskbar widget didnt have any difference with me...

mikevaughn83 commented 11 years ago

Here's a video of the bug: http://www.youtube.com/watch?v=8f03Y7ABDJU

Looking at my plasma-desktop-appletsrc, I think I figured out the problem. In the Advanced tab under the Icons KCM (System Settings -> Appearance), I have the size of Panel icons set to 256, so that widget icons in the panel use up the maximum available space (e.g., the size of the Show Dashboard widget would be ~64 pixels on a panel that's 64 pixels tall or wide). But with WorkFlow, instead of adjusting to the size of the panel, it's just setting its size to whatever is set in the Icons KCM. Hopefully this is making sense. I can do another video explaining it if needed, and/or pastebin my plasma-desktop-appletsrc.

EDIT: Sorry, didn't mean to close/re-open the bug.

psifidotos commented 11 years ago

Ok... you are right...:) I reproduced in 4.9, 256 size made the trick :) I'll try to track it...

psifidotos commented 11 years ago

Well I think that this is not a plasmoid's bug but a kde one in the compactRepresentation implementation

psifidotos commented 11 years ago

I added kde bugs: https://bugs.kde.org/show_bug.cgi?id=315825

Temp workaround unfortunately is to decrease the panel's icon size and make a relogin...

mikevaughn83 commented 11 years ago

I thought it might be a bug in Plasma as well, but if that's the case, why doesn't it occur with, for example, the Show Dashboard widget? It might be worth noting that the bug also occurs in the Adjustable Clock plasmoid (http://kde-look.org/content/show.php/Adjustable+Clock?content=92825). Maybe compare WorkFlow and that widget with Show Dashboard?

psifidotos commented 11 years ago

I thought it might be a bug in Plasma as well, but if that's the case, why doesn't it occur with, for example, the Show Dashboard widget? It might be worth noting that the bug also occurs in the Adjustable Clock plasmoid (http://kde-look.org/content/show.php/Adjustable+Clock?content=92825). Maybe compare WorkFlow and that widget with Show Dashboard?

Unfortunately the above plasmoids are C++ one, but WorkFlow is clean qml from version 0.2.2 and afterwards. Meaning that it uses the default mechanisms provided from KDE. So I think that we must wait until more clean qml plasmoids start using compactRepresentation (http://techbase.kde.org/Development/Tutorials/Plasma/QML/API - # Properties exported from the main QML Item )

or we could fix the code in KDE ourselves...

mikevaughn83 commented 11 years ago

Ahh, that makes sense. Thanks for clearing that up.

psifidotos commented 11 years ago

this is fixed by adding a feature of disabling the indicator....

Ok, I think that code in branch dev-disablecompact will fix the issue, if someone enables to hide the indicator.... this also fixes #71 But there is a big BUT... :) two features do not work this way: 1) Scroll wheel over the icon to change Activities 2) Triggering the KWin Script instead of pop up,

Please follow the discussion in the #71 I would like your ideas.......... Because of the small conflicts of the fix...

mikevaughn83 commented 11 years ago

I may not have time to properly follow up for a few days, just wanted to check in and let you know I'll try to do so soon. Thanks again for your continued work on this and attempting to involve me in the discussion. :)

psifidotos commented 11 years ago

Workaround for this

you can use the development branch and after installation you must add in the configuration options of the plasmoid in plasma-desktops-appletsrc file the following line:

DisableCompactRepresentation=true