psiie / PSMRC-Node

PSMinecraft Resource Converter as a website. Project forked from the PSMRC project also by me.
http://psmrc.duckdns.org/
10 stars 1 forks source link

Error upon conversion with multiple packs #8

Open Korozin opened 2 years ago

Korozin commented 2 years ago

So upon downloading the zip from this page, hosting etc.. I havent modified anything however when uploading a .zip of a 1.8 texture pack (tried with 7 different packs btw) it always returns this for both items, textures and the corresponding mip map levels

items: items

Terrain: terrain

psiie commented 2 years ago

Can you provide me a link to the packs that you have attempted to upload? I can take a look.

It should be noted that all the green squares are fallbacks. In the past, it would fallback to the original Mojang texture, but I have since removed the original Mojang texture pack from this project (legal reasons).

Another thing to note. I havn't messed with this project in a while. It could be possible that texture packs have changed enough that the converter no longer works. I'm not certain what state modern texture pack formats are these days. But I can take a look.

Korozin commented 2 years ago

I used specifically 1.7 - 1.8 versions to test with since a lot of the file names stay relatively the same, and I believe that's also what the project stated works. I'll include one of the packs I tried, most of which fall in the same line as it.

Used mediafire because of GitHub size limit https://www.mediafire.com/file/83cqto62uowflzm/%2521_aquar%25C2%25A7b%25C2%25A7li_%25C2%25A7rv%25C2%25A732.zip/file

This isn't too much of an issue as I re-worked a texture converter made by PhoenixArc to work for 1.8 packs and it works just fine. Also about the Fall-Back, you could possibly just use a default-edit as fallback, as it wouldn't use official Mojang textures, and most packs are avaliable for any content use with the proper license ;)

Edit: I would look into the issue myself, but JS is a rather foreign concept to me, and I don't have a lot of time atm. If your situation is similar than you're free to disregard the issue, otherwise have a good day / night. Whenever you read this,