Project 2 Code Review

[bhague1281]

Back-end notes

• include instructions on environment variable setup in README
• just for best practice, use bind parameters to sanitize data (even though the user id is being retrieved via passport)
  • http://docs.sequelizejs.com/en/latest/docs/raw-queries/#bind-parameter
• under the profile route, you'll want to ensure that queries are run under each promise's callback. You can't guarantee that the last query returns after the first two. Ways around this:
  • combine the first and second queries, so each link has a sum of unique clicks
  • eliminate the last query, since req.user is already loaded by Passport, and you're not using the user
• In controllers/stats.js
  • rename ul and dl to be more semantic
• In controllers/root.js
  • rename :id on line 30 to :hash, in order to correctly describe what's being passed in
  • use a .then promise on line 36

---

Front-end notes

• page-global.js
  • encapsulate the global variables associated with stats in an object. Optionally, put inside a IIFE, or use this syntax for creating the object:

var stats = stats || {
  uploaded: 0,
  downloaded: 0
}

• line 187: beneficial to assign this number as a variable that describes what the arbitrary number represents
  • Throughout:
• be careful with variable scoping, scope on a need-to-use basis. Additionally, use namespacing and/or IIFEs
• Look for areas where code can be simplified
• Do some linting