search

psilocke / CuriousLanterns

a minecraft mod
Other
0 stars 7 forks source link

[1.18.2] Request for compatibility with Skinned Lanterns #7

Closed Dr-WeiAL closed 11 months ago

Dr-WeiAL commented 1 year ago

Skinned Lanterns I checked the previous issues and did not find this mod, and then it is much smaller compared to Quark's lantern, but still larger than the vanilla lantern, I do not know if it is compatible image

Also I noticed that Macaw's Lights and Lamps has added some lanterns, this might be compatible too? image

psilocke commented 1 year ago

All lantern mods are technically compatible, they may just result in strange interference with the player model. Ive attempted to add compatibility for Skinned Lanterns in the past, but it resulted in very strange and unappealing hip models, such as certain skinned lanterns either being large and taking up much of the player model, or being too small, rendering details unnoticeable.

I can go ahead and work on adding compatibility for Macaw's Lights, but it is unlikely I will return to Skinned Lanterns in the future.

Dr-WeiAL commented 1 year ago

Well, I found that Skinned Lanterns lanterns are the same size as the head, if it looks strange then forget it image

Dr-WeiAL commented 1 year ago

image I put the lanterns from Skinned Lanterns inside large_lanterns and it looks pretty good?

psilocke commented 1 year ago

Do the guardian and you'll begin to see the issue. Abnormal shapes are the problem, and yes if people want to use then they can, but it annoys the hell out of me to see it so janky.

If its wanted enough, I'll add support. It just won't be perfect.

Dr-WeiAL commented 1 year ago

Uh, I added a medium sized lantern and made it compatible with Skinned Lanterns and have submitted it to Pull requests https://github.com/psilocke/CuriousLanterns/pull/10 image

psilocke commented 1 year ago

I have encountered render issues regarding some of the soul lantern variants. If i recall, this is what stopped me from continuing in the past, as some soul lanterns use their normal lantern counterpart textures, and my currently system does not account for that due to its automation.

Ive been working trying to find a way to fetch the block texture rather than using a hard coded resource location pointer, but have yet to find a solution. Because of this, Skinned Lanterns combability will have to be postponed until I can find a way to fix the missing textures.

Dr-WeiAL commented 1 year ago

image Well I noticed that too, it's really a problem Unfortunately, I can't help much for now...