psiz-org / psiz

A python package for inferring psychological embeddings.

https://psiz.org

Apache License 2.0

31 stars 7 forks source link

Default initializer for Students t is faulty #18

Closed andrewjlee0 closed 3 years ago

andrewjlee0 commented 3 years ago

The default n_dim parameter isn't initialized correctly when no value is provided by the user.

bug

roads commented 3 years ago

Hi @andrewjlee0,

Good catch. The n_dim argument has been removed (commit 3e49e236ce30f104257a97a8fe8514ca2de37a2f) since it is redundant with the free parameter alpha. Originally this was included to help users pick a reasonable default (i.e., van der Maaten suggests alpha=n_dim-1). This decision is now left up to the user.