Closed dawsbot closed 10 years ago
I'm glad you took the time to take a look at this issue, but I see numerous problems with this. I just can't see myself merging this in without significant changes.
Here is some feedback:
price_currency
and item
. server_time
is not present in the v3 output, and as is my ticker
method would return a different format than yours, it would contain the "ticker" wrapper object that can be seen in the v2 output that is not present in the v3 output.fee
api method if it still works. Seems like an unnecessary breaking change.makePublicApiRequest
as an example. I'd basically need to rewrite most of that.pair
parameter should instead be made to accept a pair or pairs, or an object with limit specified optionally and the pair or pairs. Basically, take advantage of the dynamic nature of javascript and treat the parameter differently whether it is passed in as a string, array or object. This ties in with the above note.I just don't think this is the right approach overall, so I'm going to close this. I really appreciate that you submitted this pull request though.
Thank you for your response, I will take your advice and try to improve my programming for my future endeavors.
Removes Public API calls for v2 functions and implements v3. In addition, you can now enter a value in to the "limit" field to restrict how many output values you receive on calls to
trades()
anddepth()
. Resolves tickets #4 and #10.Removes function:
fee()
Adds function:info
Adds optional "limit" field to:
trades()
depth()