search

psliwa / PdfBundle

This bundle integrates Symfony2 with PHPPdf library.
http://ohey.pl
MIT License
120 stars 45 forks source link

Tagging repository #52

Closed verschoof closed 7 years ago

verschoof commented 10 years ago

Hi,

Is it possible to tag this bundle with Semantic Versioning?

http://semver.org/

psliwa commented 10 years ago

I'm not sure the semantic versioning for this bundle is needed. This bundle is only an integration layer for PHPPdf library - the code is not changing very fast because the main features are in PHPPdf.

verschoof commented 10 years ago

The tagging concept is not based on the speed that the code is moving on, but if you can make tag 1.0.0 so I can remove the dev-master from my composer.json, would be nice.

Spomky commented 10 years ago

+1

psliwa commented 10 years ago

Semantic version and tags are not exactly the same concept. As I said, I'm not sure the tags with 3 numbers is needed in project like this. I'm not refusing this idea, but only I loudly thinking about it. Maybe making tag 1.0.0 for current version is a good idea, but there is a big probability there will never be 2.0.0 version - that I mean when I said I'm not sure about this.

But I agree the tags are welcome but I'm not sure in what form: x.x, x.x.x. or 0.x.x

verschoof commented 10 years ago

0.1.2

0 = this number changes when there are BC breaks. 1 = this number changes when you add new features 2 = this number changes when you add a bug fix

So I don't know why why there never will be a 2.0.0?

Spomky commented 10 years ago

@psliwa you should read the following article, really helpful: http://php-and-symfony.matthiasnoback.nl/2014/09/semantic-versioning-for-bundles/

psliwa commented 10 years ago 
So I don't know why why there never will be a 2.0.0?

Because there probably will not be any BC-breaks on bundle level. Yes, "probably" - there is no 100% certainty, so I haven't refused this idea.

@Spomky that article is about something else. It is about keep library and bundle versioning together. I already know what is semver, you can trust me. PHPPdf supports semvers from the begining ;)

I thought over that and I will create 1.0.0 tag. It does not hurt us, but give us more flexiblity in the future.