Ctrl / Cmd + Click no longer opens project in vendor directory

[andyexeter]

When I Ctrl + Click on a package in the composer.json file it no longer navigates to that package within the vendor directory. Instead it now opens https://schemastore.azurewebsites.net/schemas/json/composer.json as a new tab in the editor.

I initially thought this functionality was native to PhpStorm but after creating an issue there I was informed that the functionality is provided by this plugin.

I'm not sure when this started happening, but I was using PhpStorm 2018.3.2 when I reported it and it had been happening for a few releases before that. It is still happening using PhpStorm 2018.3.4 and v1.0.26 of this plugin.

Are you able to fix this? It was a really useful feature. Below is a gif showing what currently happens when using Ctrl + Click on a package:

[speto]

Same here. Navigation feature hasn't been working for last months. Now I'm on PhpStorm 2018.3 and plugin v1.0.26. Behaviour is same as @andyexeter described.

[johnpancoast]

This lost/broken behavior was very important to traverse and learn dependencies directly in the IDE. Any word from the maintainer(s)?

[psliwa]

Thanks for reporting the issue @andyexeter and @speto. After my quick investigation I think this is not the plugin issue. PhpStorm introduced built-in json schema features, eg. to composer.json file and right now cmd+click on json key opens json-schema definition as far as I can see. It looks like new PhpStorm features hide some features of this plugin - soon I will look into it if I can do something with that.

@johnpancoast I cannot effort to spend the same amount of time for this plugin as I used to, so please skip putting me on the spot like this. Please have in mind a lot of open source projects are voluntary work for the community exactly the same as this plugin. So you are not a client who can demand something because you paid for the product, you are the part of this community and you can contribute in various ways - eg. by raising a ticket as @andyexeter did, confirming the issue as @speto did, provide more information, prepare PR, fix typos in docs or code, propose new features etc. Everyting with culture and respect to the others.

[johnpancoast]

@johnpancoast I cannot effort to spend the same amount of time for this plugin as I used to, so please skip putting me on the spot like this. Please have in mind a lot of open source projects are voluntary work for the community exactly the same as this plugin. So you are not a client who can demand something because you paid for the product, you are the part of this community and you can contribute in various ways - eg. by raising a ticket as @andyexeter did, confirming the issue as @speto did, provide more information, prepare PR, fix typos in docs or code, propose new features etc. Everyting with culture and respect to the others.

@psliwa, whoa, I think you completely misunderstood my post to be more negative than it was. I was simply stating that this is an important feature and that, as @speto pointed out, this functionality has been broken for months. So I was asking if there was a status update from the maintainers which is far from unordinary. Just because I'm asking for a status update on an important broken feature does not mean that I'm demanding anything, or that I misunderstand how open source works, or that I'm unwilling to help. Quite the contrary.

It's fair for the community to ask for a status update, especially because of the fact that this is an open source project, and you said yourself you have less time to devote to this project which means it's even more fair for the community to ask for status updates or pointers on where problems lie so they can help you and the project and all of the people that depend on this project working properly. How else is the community supposed to know the status or how/if they can help? That's how open source works. The community asking for status updates on important issues is precisely how the community can help you or get important answers on features they rely on, but that doesn't mean they won't help just because they asked for a status update. Perhaps I should've clarified my willingness to help.

I apologize if my post seemed negative or if I asked too soon, but it seemed fair to ask since this issue has been ongoing for a long time. I wasn't trying to put you on the spot. I was asking for an update so the community can possibly help. The answer you gave in your first paragraph was really all that I was asking for. Thank you for that and this lib.

[psliwa]

@johnpancoast probably I misinterpreted your previous comment - in Polish such sentence has rather negative sense, but in English probably not. In written communication a lot of meaning is lost, because tone or emotions are hard to express just writting, so reader may get something diffrently than writter's intentions. I apologize for that.

[johnpancoast]

Hi @psliwa, I realized it may have been due to language differences too, and also the fact that text communication can be misunderstood, like you said. I was probably too short and blunt in my message and I can see how it could have been read negatively. It was a simple misunderstanding which was partially my fault. No hard feelings. All is good.

[psliwa]

I checked the issue in more details. I did an experiment, I configured plugin in order to work with different file name than composer.json (eg. composer-bak.json) and in such case this feature works correctly, so the plugin logic works ok. I think PhpStorm new json-schema and composer features hide this particular feature. I will share with my findings in the PhpStorm issue what @andyexeter created: https://youtrack.jetbrains.com/issue/WI-44731

[psliwa]

I got info from Anton (PhpStorm guy) how to fix this issue (https://youtrack.jetbrains.com/issue/WI-44731#focus=streamItem-27-3762877.0-0). The fix will be available in the next release.