search

psliwa / image-optimizer

Image optimization / compression library. This library is able to optimize png, jpg and gif files in very easy and handy way. It uses optipng, pngquant, pngcrush, pngout, gifsicle, jpegoptim and jpegtran tools.
MIT License
909 stars 141 forks source link

Keep BC in ChainOptimizer #48

Closed umpirsky closed 6 years ago

umpirsky commented 6 years ago

As described in https://github.com/psliwa/image-optimizer/pull/47.

umpirsky commented 6 years ago

@psliwa Can you please take a look?

umpirsky commented 6 years ago

@psliwa Ping.

umpirsky commented 6 years ago

@psliwa Pong.

psliwa commented 6 years ago

My reasoning about not accepting this PR is here: https://github.com/psliwa/image-optimizer/pull/47#issuecomment-363890458. It would introduce BC-break once again when I release it as 1.1.x or even as 1.2.x. Releasing this as 2.x.x won't improve anything, because cleaner constructor signature is IMHO without default parameters. In the future I will be more strict about BC-breaks and semantic versioning, even if I didn't commit to semantic versioning before (my idea was to have minior.patch.bug-fix approach, but probably it is less intuitive for the users).

umpirsky commented 6 years ago

OK, thanks. But I still think this BC break was unnecessary. :)