Bump psr/log dependency

psliwa / image-optimizer

Image optimization / compression library. This library is able to optimize png, jpg and gif files in very easy and handy way. It uses optipng, pngquant, pngcrush, pngout, gifsicle, jpegoptim and jpegtran tools.

MIT License

906 stars 141 forks source link

Bump psr/log dependency #64

Closed pinkeen closed 5 years ago

pinkeen commented 5 years ago

I've got a similar problem to #59. Composer fails to install a big project due to some dependency conflict in this package.

Composer only shows a cryptic message exactly like in the issue instead of providing precise information, however, experimentally I was able to trace it to psr/log version. php-fig/log v1.1.0 has been released recently and this breaks all of our builds.

There are no BCs between 1.0 and 1.1 so this should be totally safe to bump.

umairali commented 5 years ago

@pinkeen can you suggest any this how can i install

free6k commented 5 years ago

@umairali you can add this fork temporary: add in own composer.json:

"repositories": [
    {
      "type": "vcs",
      "url": "git@github.com:pinkeen/image-optimizer.git"
    }
  ],

and rerun composer update or install

umairali commented 5 years ago

@free6k thank you

Jean85 commented 5 years ago

Hello there, I'm the guy who tagged psr/log 1.1.0. Since that package is following Semantic Versioning, for you it's safe to require it as ^1.0, and allow both 1.0.x and 1.1.x. See also Composer docs.

pinkeen commented 5 years ago

Well the strangest thing is that it somehow breaks dependency resolution:

I can't imagine any other package in the project explicitly requires psr/log 1.1+ :)
There's no explicit error that would indicate problem with this package
Why composer won't just install psr/log 1.0?

Maybe I will investigate this sometime, this is not the first time I see strange composer failures like this.

psliwa commented 5 years ago

https://github.com/psliwa/image-optimizer/pull/65 merged.