psliwka / vim-smoothie

Smooth scrolling for Vim done rightšŸ„¤
MIT License
988 stars 27 forks source link

No smooth scroll in Visual modes #12

Closed anihm136 closed 3 years ago

anihm136 commented 4 years ago

When a visual selection is active, the smooth scroll action does not work

psliwka commented 4 years ago

This is a valid issue indeed. Not sure how to fix this yet (simply adding new mappings won't work, because the plugin issues normal mode commands internally), but I'll be glad to review a PR.

subnut commented 3 years ago

@anihm136 @zhixuan-lin @karb94 @WhyNotHugo @jaredramirez @mitchellwrosen @nomasprime @Melkster

Try #21 Make sure :echo has('nvim') || has('patch-8.2.1978') returns 1

anihm136 commented 3 years ago

@subnut This works perfectly for me! The other changes in the PR are also helpful. Thanks!

WhyNotHugo commented 3 years ago

@subnut it returns 1 for me.

subnut commented 3 years ago

@subnut it returns 1 for me.

@WhyNotHugo Then vim-smoothie in PR #21 should automatically work in Visual mode too. Does it not?