Feature/zt zz zb - Githubissues

psliwka / vim-smoothie

Smooth scrolling for Vim done right🥤

MIT License

988 stars 27 forks source link

Feature/zt zz zb #31

Closed aidando73 closed 2 years ago

aidando73 commented 3 years ago

What?

This is a pull request that transforms the zt zz z. zb commands to smoothie commands. It takes into account folds and scrolloff.

Why?

These changes will decrease cognitive load for users using the zt zz z. zb commands as it's easier to follow.

How?

Coined the term disjoint scrolls to describe scrolling that is separate from the cursor (let me know if you want a different name)
Changed the step_down and step_up functions to perform disjoint scrolls.
Added functions smoothie#top, smoothie#bottom, smoothie#middle for zt, zb, zz commands respectively
These mappings will go into experimental mappings.

csaez commented 3 years ago

I just tried your fork and it works great! :tada: Thanks for implementing zt, zz and zb!

blurgyy commented 2 years ago

Hi @REslim30, I think there is a debugging line not removed in your fork:

https://github.com/REslim30/vim-smoothie/blob/25f108a758f8599bb9b043d050c7379efc362276/autoload/smoothie.vim#L445

It causes every zz to print a line number, which is slightly annoying. Other than that your fork works great!

blurgyy commented 2 years ago

Hi @REslim30, during more daily testing of your fork, I found that when a wrapped long line is partially visible at the bottom of current buffer, zz will become buggy and jumps around instead of taking current line to the middle of the buffer, zb and zt work fine though.

psliwka commented 2 years ago

Hi @REslim30, thanks for your contribution! Ultimately I decided to implement zz and friends in another way with f2aaab110b49da21ab7abf4858173e3194109f6a so I'm going to close this PR, but your effort in making vim-smoothie better is highly appreciated!

aidando73 commented 2 years ago

Hi @REslim30, thanks for your contribution! Ultimately I decided to implement zz and friends in another way with https://github.com/psliwka/vim-smoothie/commit/f2aaab110b49da21ab7abf4858173e3194109f6a so I'm going to close this PR, but your effort in making vim-smoothie better is highly appreciated!

Sorry! I forgot about this PR. Thanks for the review @blurgyy @csaez.

Good to hear the feature is in in another form. Keep up the good work