Add command to enable and disable smoothie

pbzweihander commented 4 years ago

In some situations, such as the terminal is getting slow, we may want to disable smoothie.

So I added SmoothieEnable and SmoothieDisable command to enable and disable smoothie quickly.

expelledboy commented 4 years ago

Nice work, how about rather set/unset a flag in the functions that have key bindings, then bind/unbind the default key bindings? That way if you create your own custom keybindings (see https://github.com/psliwka/vim-smoothie/pull/3) this still works 💪

psliwka commented 4 years ago

Sorry, @pbzweihander. I like the idea, but not the implementation.

As @expelledboy indicated, mapping and unmapping default keybindings makes it hard to support custom mappings, introduced by #3.
Calling smoothie#enable() during plugin/smoothie.vim execution breaks lazy loading, sourcing whole autoload script on vim startup.

That being said, thank you so much for your efforts in making vim-smoothie better! Feel free to reopen this PR or submit another one in case you rework your feature to take into account the issues mentioned above. It would be much appreciated 🙂

psliwka / vim-smoothie

Add command to enable and disable smoothie #5