search

psmedley / qt6-webengine-os2

BSD 3-Clause "New" or "Revised" License
2 stars 0 forks source link

Multiple warnings compiling source which includes page_allocator_internals_os2.h #13

Open psmedley opened 1 year ago

psmedley commented 1 year ago

https://github.com/psmedley/qt6-webengine-os2/blob/6.5.x/src/3rdparty/chromium/base/allocator/partition_allocator/page_allocator_internals_os2.h

Given the crashes in code around here in Qt 6.4.x, suggest these should be investigated.

psmedley commented 1 year ago
Below is an example of the warning with the 6.4.x version: `In file included from ../../../../../src/3rdparty/chromium/base/allocator/partition_allocator/page_allocator.cc:28: ../../../../../src/3rdparty/chromium/base/allocator/partition_allocator/page_allocator_internals_os2.h: In function 'bool partition_alloc::internal::TrySetSystemPagesAccessInternal(uintptr_t, size_t, partition_alloc::PageAccessibilityConfiguration)': ../../../../../src/3rdparty/chromium/base/allocator/partition_allocator/page_allocator_internals_os2.h:123:24: warning: invalid conversion from 'uintptr_t' {aka 'unsigned int'} to 'PVOID' {aka 'void*'} [-fpermissive] 123 return MyDosSetMem(address, length, PAG_DECOMMIT) == NO_ERROR; ^~~
uintptr_t {aka unsigned int}
../../../../../src/3rdparty/chromium/base/allocator/partition_allocator/page_allocator_internals_os2.h:19:26: note: initializing argument 1 of 'APIRET partition_alloc::internal::{anonymous}::MyDosSetMem(PVOID, ULONG, ULONG)' 19 APIRET MyDosSetMem(PVOID base, ULONG length, ULONG flags) { ~~^~~~ ../../../../../src/3rdparty/chromium/base/allocator/partition_allocator/page_allocator_internals_os2.h:124:22: warning: invalid conversion from 'uintptr_t' {aka 'unsigned int'} to 'PVOID' {aka 'void*'} [-fpermissive] 124 return MyDosSetMem(address, length, PAG_COMMIT ^~~
uintptr_t {aka unsigned int}
../../../../../src/3rdparty/chromium/base/allocator/partition_allocator/page_allocator_internals_os2.h:19:26: note: initializing argument 1 of 'APIRET partition_alloc::internal::{anonymous}::MyDosSetMem(PVOID, ULONG, ULONG)' 19 APIRET MyDosSetMem(PVOID base, ULONG length, ULONG flags) { ~~^~~~ ../../../../../src/3rdparty/chromium/base/allocator/partition_allocator/page_allocator_internals_os2.h: In function 'void partition_alloc::internal::SetSystemPagesAccessInternal(uintptr_t, size_t, partition_alloc::PageAccessibilityConfiguration)': ../../../../../src/3rdparty/chromium/base/allocator/partition_allocator/page_allocator_internals_os2.h:133:30: warning: invalid conversion from 'uintptr_t' {aka 'unsigned int'} to 'PVOID' {aka 'void*'} [-fpermissive] 133 APIRET arc = MyDosSetMem(address, length, PAG_DECOMMIT); ^~~
uintptr_t {aka unsigned int}
../../../../../src/3rdparty/chromium/base/allocator/partition_allocator/page_allocator_internals_os2.h:19:26: note: initializing argument 1 of 'APIRET partition_alloc::internal::{anonymous}::MyDosSetMem(PVOID, ULONG, ULONG)' 19 APIRET MyDosSetMem(PVOID base, ULONG length, ULONG flags) { ~~^~~~ ../../../../../src/3rdparty/chromium/base/allocator/partition_allocator/page_allocator_internals_os2.h:140:30: warning: invalid conversion from 'uintptr_t' {aka 'unsigned int'} to 'PVOID' {aka 'void*'} [-fpermissive] 140 APIRET arc = MyDosSetMem(address, length, PAG_COMMIT ^~~
uintptr_t {aka unsigned int}
../../../../../src/3rdparty/chromium/base/allocator/partition_allocator/page_allocator_internals_os2.h:19:26: note: initializing argument 1 of 'APIRET partition_alloc::internal::{anonymous}::MyDosSetMem(PVOID, ULONG, ULONG)' 19 APIRET MyDosSetMem(PVOID base, ULONG length, ULONG flags) { ~~^~~~ ../../../../../src/3rdparty/chromium/base/allocator/partition_allocator/page_allocator_internals_os2.h: In function 'void partition_alloc::internal::FreePagesInternal(uintptr_t, size_t)': ../../../../../src/3rdparty/chromium/base/allocator/partition_allocator/page_allocator_internals_os2.h:153:29: warning: invalid conversion from 'uintptr_t' {aka 'unsigned int'} to 'PVOID' {aka 'void*'} [-fpermissive] 153 APIRET arc = DosFreeMemEx(address); ^~~
uintptr_t {aka unsigned int}
In file included from C:/usr/include/os2.h:39, from ../../../../../src/3rdparty/chromium/base/os2/os2_toolkit.h:30, from ../../../../../src/3rdparty/chromium/base/allocator/partition_allocator/page_allocator.cc:22: C:/usr/include/os2emx.h:13568:36: note: initializing argument 1 of 'APIRET DosFreeMemEx(PVOID)' 13568 APIRET APIENTRY DosFreeMemEx(PVOID pv); ~~^~ ../../../../../src/3rdparty/chromium/base/allocator/partition_allocator/page_allocator_internals_os2.h: In function 'void partition_alloc::internal::RecommitSystemPagesInternal(uintptr_t, size_t, partition_alloc::PageAccessibilityConfiguration, partition_alloc::PageAccessibilityDisposition)': ../../../../../src/3rdparty/chromium/base/allocator/partition_allocator/page_allocator_internals_os2.h:177:33: warning: return-statement with a value, in function returning 'void' [-fpermissive] 177 return TrySetSystemPagesAccess(address, length, accessibility); ~~~~~^~~~~~~~~~ ../../../../../src/3rdparty/chromium/base/allocator/partition_allocator/page_allocator.cc: In function 'uintptr_t partition_alloc::internal::SystemAllocPages(uintptr_t, size_t, partition_alloc::PageAccessibilityConfiguration, partition_alloc::PageTag)': ../../../../../src/3rdparty/chromium/base/allocator/partition_allocator/page_allocator.cc:139:42: warning: invalid conversion from 'uintptr_t' {aka 'unsigned int'} to 'void*' [-fpermissive] 139 internal::SystemAllocPagesInternal(hint, length, accessibility, page_tag); ^~~~
uintptr_t {aka unsigned int}
../../../../../src/3rdparty/chromium/base/allocator/partition_allocator/page_allocator_internals_os2.h:73:38: note: initializing argument 1 of 'void partition_alloc::internal::SystemAllocPagesInternal(void, size_t, partition_alloc::PageAccessibilityConfiguration, partition_alloc::PageTag)' 73 void SystemAllocPagesInternal(void hint, ~~^~~~ ../../../../../src/3rdparty/chromium/base/allocator/partition_allocator/page_allocator.cc:139:41: warning: invalid conversion from 'void*' to 'uintptr_t' {aka 'unsigned int'} [-fpermissive] 139 internal::SystemAllocPagesInternal(hint, length, accessibility, page_tag); ~~~~~~~~^~~~~~~~~
void*

`

psmedley commented 1 year ago

Attached as well for better readability stderr.txt

psmedley commented 1 year ago

I cleaned this file up for 6.4.x and am currently rebuilding. It will be interesting to see if it makes any difference