psmokotnin / osm

Open sound meter. FFT based application for tuning sound systems.
GNU General Public License v3.0
234 stars 37 forks source link

Add Leq/LAeq Times | Adjustability? #94

Open Spacelord09 opened 4 months ago

Spacelord09 commented 4 months ago

Hey, great project! Could you add 10min + 120min Leq/LAeq?

Is it just a matter of changing this code snippet and then recompiling it?

src/math/leq.cpp

const std::unordered_map<std::size_t, QString> Leq::m_timeMap = {
    {  1 * 60, "  1 min" },
    {  5 * 60, "  5 min" },
    { 10 * 60, " 10 min" },
    { 15 * 60, " 15 min" },
    { 30 * 60, " 30 min" },
    { 60 * 60, " 60 min" },
    { 120 * 60, "120 min" },
};

Another idea would be to make the whole thing adjustable in the UI. Is this possible with the current architecture?

Spacelord09 commented 3 months ago

@psmokotnin ?

psmokotnin commented 3 months ago

Yeah, already added it to my list for upcoming release

Spacelord09 commented 3 weeks ago

Implemented in b15a7c9

Thanks @psmokotnin!

If user adjustability is not planned, please close the issue.

psmokotnin commented 2 weeks ago

adjustability is in the plan. That's why I'm closing it now :)