psolin / cleanco

Company Name Processor written in Python
MIT License
322 stars 95 forks source link

Move data away from main class (into country-specific modules?) #11

Closed petri closed 9 years ago

petri commented 9 years ago

To support for example abbreviation expansion for other languages than english, it would be better if the data was split into submodules rathen than kept embedded in the class.

For example, add a "data" subpackage to contain language modules with names from the ISO 639-1 standard. So current ones would be in module "data/uk.py".

If this is ok, I can provide an implementation.

psolin commented 9 years ago

I agree, the data looks too crowded in the main code -- it takes up nearly half of the space. I wanted to split it out a long time ago, but could never really figure out the correct way to do it. I always envisioned a small sqlite file, but this might be a better way. Anything you can do here will obviously be appreciated.

petri commented 9 years ago

Very well. Could you give me commit (write) rights to the repository (see repository settings)? That would perhaps speed up things a bit, given the time zone difference between us. As long as you keep the repository ownership to yourself, you can, if need be, always kick me out and undo any changes you don't like ;-)

psolin commented 9 years ago

You're on here, now. Glad to have you on board.

petri commented 9 years ago

Thanks :)

petri commented 9 years ago

Done in 8f94096