search

psolin / cleanco

Company Name Processor written in Python
MIT License
322 stars 95 forks source link

Fix name parsing #24

Closed jachymb closed 7 years ago

jachymb commented 7 years ago

This fixes issue #23

petri commented 7 years ago

It seems this PR does not pass the tests (on Python 2.7). Please install pytest, cd to the cleanco directory and run "pytest". Do the tests pass for you?

I just added better testing support to the upstream master. Please merge the changes into your fork, install tox and run it. That will run tests on both Python 2.7 & 3.5 for you (presuming you have both installed). When I tried that, your fork (PR) did not pass tests on Python2.7

jachymb commented 7 years ago

Fixed an unicode typo and python2 is now satisfied too.

jachymb commented 7 years ago

Are there any further obstacles to merge?

jachymb commented 7 years ago

note: this also fixes #27