search

pspdev / prxtool

A simple tool to manipulate Sony PSP(tm) PRX files
Other
64 stars 27 forks source link

prxtoll bugs I found #5

Open ogamespec opened 8 years ago

ogamespec commented 8 years ago

Bug in msub decoding

All msub instructions use $zr instead proper RS register, for example:

0x0000E5B8: 0x00C1002E '....' - msub $zr, $at

Should be:

0x0000E5B8: 0x00C1002E '....' - msub $a2, $at

Bug in vi2uc.q decoding

0x0000D420: 0xD03C83FE '..<.' - vi2uc.q R702, C030

Destination is always single register. Following instruction should be decoded as follow:

0x0000D420: 0xD03C83FE '..<.' - vi2uc.q S723, C030

sharkwouter commented 1 year ago

Can anyone confirm if this is still the case?

artart78 commented 1 year ago

Yup, I checked and it's still the case. Also, psp-binutils returns the correct result, and ghidra-allegrex too. It shouldn't be too hard to fix, but prxtool is mostly useless nowadays anyway since we have ghidra-allegrex.