search

pspdev / psp-packages

https://pspdev.github.io/psp-packages/
The Unlicense
26 stars 14 forks source link

simplified patch for mbedtls #142

Closed tpimh closed 6 months ago

tpimh commented 6 months ago

Not a functional change, just simplifying existing patch since sockaddr_storage is now supported, thus doesn't need to be patched out anymore.

Patch went from 218 lines to 182.

tpimh commented 6 months ago

@bucanero Is there a reason mbedtls is at version 2.16.6? The patch applies cleanly at least to 2.16.12, so maybe it's good idea to update the package as well in this PR?

I am a bit confused by the source package naming. Here 2.16.6 archive and everything before it has a suffix apache to it's name, everything after this version comes without suffix. Was the license changed?

bucanero commented 6 months ago

@tpimh I was using 2.16 because it was the LTS branch, probably 2.16.6 was the one available at the time I was working on it on another platform ( ps3/ps4)

If you want, go ahead and update it to 2.16.12, but in any case I suggest to test with libcurl if downloading content from HTTPS works ok.

You can test with the sample Joker app or you can also test building my homebrew pkgi-psp , both use libcurl to connect to https servers.

tpimh commented 6 months ago

Yes, sure! I got Joker built today and it's working. I can probably update to the new LTS as well, but the patch will need some adaptation.

sharkwouter commented 6 months ago

Since the app mentioned was confirmed to work, I'm going to merge this. Updating the version can be done in another PR. Thanks for the contribution!