pspdev / psp-packages

https://pspdev.github.io/psp-packages/
The Unlicense
24 stars 13 forks source link

Use upstream SDL2 #21

Closed sharkwouter closed 2 years ago

sharkwouter commented 2 years ago

Upstream SDL2 is currently in a mostly usable state for the PSP, even if it's not quite on par with our fork yet. We should make PRs to upstream to get it to the point where it's at least as good and ship it instead of our fork. This will reduce work for us and make sure SDL2 for PSP stays in a good spot.

Before we do this, here is a list of changes needed in upstream SDL:

sharkwouter commented 2 years ago

Here we need to make sure the quality of the commits is good, changes are as small as needed and PRs are specific to one issue/improvement. We want the end result to be maintainable and we want upstream to be able to accept our changes.

We also don't want to repeat loading a small amount of textures causing out of memory errors because the vram is full.

sharkwouter commented 2 years ago

I tested the old commit for rendering to texture and it's not really a good implementation. It works if there is only 1 texture being rendered to. If there are more layers, it doesn't work anymore.

sharkwouter commented 2 years ago

Most of the rendering issues we face have been at least partially fixed in this PR to one of the SDL2 forks for PSP: https://github.com/joel16/SDL2/pull/5

sharkwouter commented 2 years ago

Upstream SDL is now used in the toolchain.