search

pspdev / psp-packages

https://pspdev.github.io/psp-packages/
The Unlicense
19 stars 13 forks source link

Add libzip 1.9.2 #83

Closed bucanero closed 1 year ago

bucanero commented 1 year ago

the latest libzip from https://libzip.org/

sharkwouter commented 1 year ago

Thanks for the PR @bucanero! It seems the automated build fails because xz is not available. Could you add it to the apk add steps found in this file?: https://github.com/pspdev/psp-packages/blob/master/.github/workflows/build.yml

bucanero commented 1 year ago

hi @sharkwouter , I have added xz based on your feedback

Btw, libzip also provides a .tar.gz release, so if needed/preferred I can switch to https://libzip.org/download/libzip-1.9.2.tar.gz and update the sha256 hash.

bucanero commented 1 year ago

It seems the automated build is still failing.

my bad, I committed a fix so it can change directory as expected cd "$pkgname-$pkgver" (cd libzip-1.9.2)

bucanero commented 1 year ago

another fix, seems like prepare() can't be empty

sharkwouter commented 1 year ago

You can probably just remove prepare

bucanero commented 1 year ago

You can probably just remove prepare

prepare() { } removed. Let's see if it works. 😄

bucanero commented 1 year ago

thanks for the feedback and tips on the .pc file. 👍

I've re-added prepare() and added a patch to update libzip.pc.in as needed. Everything should work as expected now. 😄

sharkwouter commented 1 year ago

Thanks! Looks good to me