search

pspdev / psplibraries

A script to automatically build open-source libraries for PSP homebrew development.
47 stars 45 forks source link

I added some more libraries. #2

Closed take-cheeze closed 13 years ago

ooPo commented 13 years ago

I like the changes except for the part where you're copying over a premade config.sub instead of creating a patch. This may work for now but will lead to problems with maintenance in the future as libraries diverge and start using different versions of this file.

Can you redo these changes with a patch for each library instead?

take-cheeze commented 13 years ago

From my experience most config.sub is copy of http://cvs.savannah.gnu.org/viewvc/config/config/config.sub and never seen a special config.sub that has an special feature. Copying config.sub works most of the time(I'll be pleased to fix an error when there are any problem). So I think creating patch only for config.sub is waste.

Though I think I should add diff of config.sub to a patch that needs other fix other than config.sub like my ruby port. Or maybe write some kind of script like for i in $(find $PROECT_PATH -name "config.sub"); do cp a-directory/config.sub $i; done to prepare for a move of config.sub in a future.

(Sorry if there is miss point)

ooPo commented 13 years ago

Well, let's give it a try then. If it becomes an issue, we can generate some patches.