search

pspdev / psplibraries

A script to automatically build open-source libraries for PSP homebrew development.
47 stars 45 forks source link

Use psp-g++ as compiler for squirrel #44

Closed sharkwouter closed 4 years ago

sharkwouter commented 4 years ago

It was failing to build in my docker environment with an error saying I didn't have c++ compiler. Using psp-g++ fixes this.

carstene1ns commented 4 years ago

This is actually a build system bug then. CC should never be used for c++ compiler.

sharkwouter commented 4 years ago

Good point. I'm not quite sure how that could be solved, though. It's a bit odd that it will use gcc. Maybe I should remove the CC variable there?

carstene1ns commented 4 years ago

Have looked at the source. They really compile cpp files with gcc there. :/ So this patch is ok. There is also version 3.1 released since then, but it would involve further patching.

sharkwouter commented 4 years ago

This seems to no longer be an issue with the new GCC version. GCC will compile C++ files just fine. Should we still apply this change?

carstene1ns commented 4 years ago

I would say, let's stay like we have it now. Since it works (...and hope they fix their build system one day)

sharkwouter commented 4 years ago

Okay, then I'll close it for now.