search

pspdev / psplibraries

A script to automatically build open-source libraries for PSP homebrew development.
47 stars 45 forks source link

Optional stripping of binary passed to create_pbp_file #59

Closed dbeef closed 4 years ago

dbeef commented 4 years ago

As I am aware not everyone uses CMake in their everyday projects, I want to reach out and propose this optional STRIP argument to the create_pbp_file macro for more novice users.

carstene1ns commented 4 years ago

Default Makefile strips always: https://github.com/pspdev/pspsdk/blob/9e63c70dad08f25b53bc41add9efdc925add43bf/src/base/build.mak#L196-L201

I would like to make this conditional on the CMAKE_BUILD_TYPE, if possible. If Release, do stripping

carstene1ns commented 4 years ago

Dumb question, but are these post_build commands always executed in same order? Otherwise we would need to add some dependency management here.

dbeef commented 4 years ago

Yes, this is deterministic depending on which command has been declared first.