search

pspdev / psplibraries

A script to automatically build open-source libraries for PSP homebrew development.
47 stars 45 forks source link

CMake targets don't like MinGW #82

Closed krystalgamer closed 2 years ago

krystalgamer commented 3 years ago

This issue is more random than ever, thus by even version of it with and without extension prevents it all together.

It needs to be 2 steps because by default msys cp doesn't allow to remove the extension.

carstene1ns commented 3 years ago

IMO this should be fixed in the cmake toolchain by adding the exe suffix on windows instead of this hackery.

If I prepare a patch, will you test it on mingw?

krystalgamer commented 3 years ago

I guess

wally4000 commented 2 years ago

Is this still required with current cmake file?

sharkwouter commented 2 years ago

Yeah, this should be added still.

sharkwouter commented 2 years ago

To clarify my previous statement. I agree with Carsten. This should be in the toolchain file. This PR should probably be closed.