Add MUSIC_PATH option to CreatePBP.cmake

pspdev / pspsdk

An open-source SDK for PSP homebrew development.

Other

856 stars 143 forks source link

Add MUSIC_PATH option to CreatePBP.cmake #212

Closed kathrindc closed 3 months ago

kathrindc commented 3 months ago

Small change to allow inclusion of an snd0.at3 file in the PBP created by the CMake script. Already using this change locally, thought I might as well see if it could be added here.

bucanero commented 3 months ago

LGTM, but I couldn't test with a sample cmake app to be sure everything still works if this MUSIC_PATH param is missing.

kathrindc commented 3 months ago

Not passing a value should be fine, since it's set as part of the oneValueArgs values, which are replaced by "NULL" if not present, seems to work fine on my machine. (of course further testing would be good tho ^-^)

diamant3 commented 3 months ago

Thanks for the PR!, Both PPSSPP and real PSP works.