pspdev / psptoolchain-allegrex

This program will automatically build and install an Allegrex compiler which is used in the creation of homebrew software for the Sony PlayStation® Portable videogame system.
MIT License
11 stars 10 forks source link

fix internal compiler error in msys2 msys #29

Closed diamant3 closed 8 months ago

diamant3 commented 9 months ago

This is the error: https://pastebin.com/jHFLmRDL that I encountered when compiling the psptoolchain-allegrex scripts on the MSYS2 (MSYS) environment, and I think this PR is the most suitable. What I found out was that there was an error in the precompiled headers of the C++ standard library or something, but I'm not sure if this fix negatively affects others except the build time. I'm not a compiler expert or anything, so please enlighten me if there's an issue with my PR. Hopefully to be merged, thanks!

diamant3 commented 9 months ago

According to msys2 people specifically from biswa96 and mati865 on my msys2 discord post, that there is no bad effects of disabling the pch except the build time may be slower than usual.

sharkwouter commented 8 months ago

Guess we'll just have to find out then. I'll do a quick test tonight, then merge.

diamant3 commented 8 months ago

Got it, Thank you!

sharkwouter commented 8 months ago

This change does seem to cause some issues for me. If I build this, should I rebuild pspsdk and some of the tools as well? It seems this affects linking:

[100%] Linking CXX executable oceanpop
Stripping binary
Calling psp-fixup-imports
Error, no sceModuleInfo section found
make[2]: *** [CMakeFiles/oceanpop.dir/build.make:443: oceanpop] Error 1
make[2]: *** Deleting file 'oceanpop'
make[1]: *** [CMakeFiles/Makefile2:83: CMakeFiles/oceanpop.dir/all] Error 2
make: *** [Makefile:91: all] Error 2

I got this when building oceanpop.

diamant3 commented 8 months ago

Sorry i forgot this one. Yes, please rebuild the pspsdk and the tools too then install.

sharkwouter commented 8 months ago

Will do

diamant3 commented 8 months ago

Thanks wouter!

sharkwouter commented 8 months ago

I just tested this once again with rebuilding the pspsdk and all packages and it worked fine. I've merged it now.

diamant3 commented 8 months ago

Thanks wouter!