Resolving issue #361: Added culture awareness to ConvertTo-UnixTime function

pspete / psPAS

PowerShell module for CyberArk Privileged Access Security REST API

https://pspas.pspete.dev

MIT License

291 stars 91 forks source link

Resolving issue #361: Added culture awareness to ConvertTo-UnixTime function #362

Closed liamwh closed 3 years ago

liamwh commented 3 years ago

Summary

This PR fixes issue #361, where the ConvertTo-UnixTime function provided invalid values to other functions when the culture is not en-US (or that of the PWV API), which are eventually used by Invoke-PASRestMethod.

Closes issues

Closes #361

pspete commented 3 years ago

Fantastic contribution @liamwh - top marks for adding a test too. Will check the PR out, but at first glance looks like it should be able to be merged without issue. Many thanks for contributing 👍🏼

liamwh commented 3 years ago

Thanks a lot! Always happy to help where possible. Love the module, keep up the good work @pspete 👍