search

psr7-sessions / storageless-mezzio-integration

MIT License
8 stars 4 forks source link

Port @dominikzogg's expressive integration to a new package #1

Closed Ocramius closed 4 years ago

Ocramius commented 5 years ago

The commit log is huge (by design), because it includes all of psr7-sessions/storageless history, and is diverging from it by just a few commits at the very HEAD of the history

dominikzogg commented 5 years ago

@Ocramius i like the idea of the separate repository. Should i do the changes here?

Ocramius commented 5 years ago

No action needed from your end: I'm already working on it, and left the comments for myself to fix 👍

dominikzogg commented 5 years ago

@Ocramius thanks for your effort

Ocramius commented 5 years ago

@dominikzogg I've ported everything: need your review/merge. This package is now under your control :+1:

Ocramius commented 5 years ago

Note: I'll have to do the packagist registration once this is merged. Please remember to use signed tags for releases.

Ocramius commented 5 years ago

Hmm, we should add roave/backwards-compatibility-check here

Ocramius commented 4 years ago

@dominikzogg any news on this? Need your review to move it forward :mag:

dominikzogg commented 4 years ago

@Ocramius sorry, didn't noticed:

Ocramius requested a review from dominikzogg on 11 Aug 2019

Will do it within the next days

Ocramius commented 4 years ago

Figured: no worries, remember that this is "your" package after it gets to 1.0.0 :P

dominikzogg commented 4 years ago

@Ocramius can we merge this? and before releasing it migrate to laminas?

Ocramius commented 4 years ago

@dominikzogg yes, once you (if you have time) make it green, we can certainly merge :+1:

I can probably bring it to green, but not in the immediate future, so if you have capacity, please feel free to take ownership of the branch as per https://github.com/psr7-sessions/storageless-zend-expressive-integration/pull/1#issuecomment-520184652

dominikzogg commented 4 years ago

I can probably bring it to green, but not in the immediate future, so if you have capacity, please feel free to take ownership of the branch as per #1 (comment)

What do you mean by ownership? that i do a PR to this ones, or do i miss something?

Ocramius commented 4 years ago

@dominikzogg you can push straight to this PR's branch

dominikzogg commented 4 years ago

@Ocramius tests are green, i would suggest to merge it and then migrate to laminas

Ocramius commented 4 years ago

Probably need to rename the repo too 🤣