psrc / urbansim2

3 stars 0 forks source link

Clean up and document data conversion #131

Closed hanase closed 6 years ago

hanase commented 6 years ago

The README instructions for data conversion is out of date. Needs a description of creating data for estimation. In addition,

Sorry @stefancoe, these could be four separate issues. Do you think you could work on some of these? Thanks!

stefancoe commented 6 years ago

Sure thing @hanase. I'll be able to work on this next week.

hanase commented 6 years ago

@stefancoe - I created the simulation and estimation caches in \\MODELSRV8\d$\opusgit\urbansim_data\data\psrc_parcel\base_year_2014_inputs, called urbansim2_cache and urbansim2_estimation_cache.

I converted them into h5 using your conversion script (which needs to be renamed and modified as suggested in #132 and #123). These hdf5 files are available on \\MODELSRV3\d$\udst\psrc_urbansim\data as psrc_base_year_2014.h5 and psrc_estimation_2014.h5.

Please update the README files with this info.

hanase commented 6 years ago

Also please add the requirement of installing pylogit into the README.

stefancoe commented 6 years ago

Hana, I have consolidated the two conversion scripts

stefancoe commented 6 years ago

And updated the readme.

hanase commented 6 years ago

@stefancoe - the conversion script throws an error:

$ python cache_to_hdf5.py --help Traceback (most recent call last): File "cache_to_hdf5.py", line 248, in sys.exit(main()) File "cache_to_hdf5.py", line 239, in main if len(args) == 2: TypeError: object of type 'NoneType' has no len()

Also, the conversion README is still referencing the estimation_cache_to_hdf5.py. Can we make the three years a default, so that user does not need to put it into the command line?

hanase commented 6 years ago

@stefancoe - Could you also please add the pylogit reference to README? Thanks!

stefancoe commented 6 years ago

@hanase - looks like you fixed the pylogit reference in the README. Thanks! I tested the data conversion script and it works for both regular and estimation cache. I fixed a typo in the data conversion README. It looks like modelsrv3 has recent data sets. When we merge newdeveloper into dev, we can have someone test the code on modelsrv3 and makes sure everything is working.