search

psrc / urbansim2

3 stars 0 forks source link

resolve sqft_per_unit and building_sqft_per_unit #169

Open stefancoe opened 5 years ago

stefancoe commented 5 years ago

@hanase sqft_per_unit is a local column on the building table and building_sqft_per_unit is a computed variable on the building table. I think we should stick with one as some dependencies are using one or the other. Perhaps not include sqft_per_unit when importing data and just compute it?

hanase commented 5 years ago

@stefancoe , the sqft_per_unit is used to determine residential sqft, which is residential_units * sqft_per_unit. Without that column in the table, you could not determine building_sqft.

I think the confusion is caused by poor naming of the variables. building_sqft_per_unit is actually total_building_sqft_per_residential_unit which is different than the sqft_per_unit column.

We should revisit all the uses and maybe rename the variables.

stefancoe commented 5 years ago

@hanase Thanks for the clarification! When/why would we want to use building_sqft_per_unit (which potentially includes non-residential square footage, right?) as opposed to sqft_per_unit. I see that it is used in price_per_unit, which is then used by ln_price_residual. Thanks!

hanase commented 5 years ago

@stefancoe This might have been the reason why we switched everything to "per sqft". Let's find the various uses and discuss it in our meeting on Monday.

stefancoe commented 5 years ago

@hanase Sounds good. I'll look at all the places it's used- seems like we should be using sqft_per_unit_imputed instead, at least when dealing with variables that are representing residential components of a building.