psrc / urbansim2

3 stars 0 forks source link

parcels.existing_units does not have number of units for residential units #170

Open stefancoe opened 5 years ago

stefancoe commented 5 years ago

This variable almost always returns square footage and not units for buildings with residential units. This is because parcels.unit_name has no records with 'residential_units'.

stefancoe commented 5 years ago

@hanase should change logic so parcels.existing_units == parcels.residential_units when parcels.residential_units is greater than 0?

hanase commented 5 years ago

@stefancoe It really depends where and how it is used. If a parcel has both, res units and non-res sqft, does the usage of this variable assumes that it gives total sqft?