pssc / ha-addon-lms

Logitech Media Server Addon for Home Assistant
GNU General Public License v3.0
56 stars 13 forks source link

Can't mount SMB share with space in name #30

Open nkm8 opened 1 year ago

nkm8 commented 1 year ago

I'm trying to mount an SMB share (I don't control the name of the share) that has a space in the name. When trying to mount the share, I get a "mount: bad usage" error.

I've tried all iterations I can think of, but it looks like the quotes I add in the config aren't reflected when the mount command is executed.

pssc commented 1 year ago

You could try a custom start up command that runs a bash script with your mount command

On Thu, 2 Mar 2023, 20:38 Nick, @.***> wrote:

I'm trying to mount an SMB share (I don't control the name of the share) that has a space in the name. When trying to mount the share, I get a "mount: bad usage" error.

I've tried all iterations I can think of, but it looks like the quotes I add in the config aren't reflected when the mount command is executed.

— Reply to this email directly, view it on GitHub https://github.com/pssc/ha-addon-lms/issues/30, or unsubscribe https://github.com/notifications/unsubscribe-auth/AANORYM6DV4HE45AWL4Z7HLW2EAL5ANCNFSM6AAAAAAVN3ETVI . You are receiving this because you are subscribed to this thread.Message ID: @.***>

nkm8 commented 1 year ago

Great suggestion - I tried this approach and everything is working great.

It's up to you if you want to leave this issue open or not to improve the existing mount behavior. If you do, I suggest checking out how another developer handled a similar issue: https://github.com/alexbelgium/hassio-addons/blob/master/.templates/92-smb_mounts.sh

Thank you!

pssc commented 1 year ago

Yes it is something I need to fix and it is an issue, glad we found a work round for you it allows me to pick this up as I have time.

On Sun, 5 Mar 2023, 04:06 Nick, @.***> wrote:

Great suggestion - I tried this approach and everything is working great.

It's up to you if you want to leave this issue open or not to improve the existing mount behavior. If you do, I suggest checking out how another developer handled a similar issue: https://github.com/alexbelgium/hassio-addons/blob/master/.templates/92-smb_mounts.sh

Thank you!

— Reply to this email directly, view it on GitHub https://github.com/pssc/ha-addon-lms/issues/30#issuecomment-1454984255, or unsubscribe https://github.com/notifications/unsubscribe-auth/AANORYNHDNBY2NZK4GSLE7DW2QGMFANCNFSM6AAAAAAVN3ETVI . You are receiving this because you commented.Message ID: @.***>