pssc / ha-addon-lms

Logitech Media Server Addon for Home Assistant
GNU General Public License v3.0
56 stars 13 forks source link

Qobuz artwork not showing on material skin when started from within HA #7

Closed jm38410 closed 2 years ago

jm38410 commented 2 years ago

Hi,

A weird bug:

When specifying skin : material and starting the lms from within HA, Qobuz artwork don't show up. Other artwork do show up in this configuration though (local music or radios)

But if I invoke directly the LMS UI from homeassistant:9000/material, Qobuz artworks do show up. (maybe a DNS problem that appears only when launching the UI from HA?)

Thanks for your help Jean-Michel

pssc commented 2 years ago

I don't use Qobuz it sounds like it needs a custom mapping in the ingress config, you will need to inspect the javascript/html to see how the failing urls are generated and we can come up with a mapping have a look at https://github.com/pssc/ha-addon-lms/blob/master/lms/rootfs-ingress/etc/nginx/servers/ingress.conf for the other mappings.

jm38410 commented 2 years ago

The javascript code to fetch cover images in the material skin looks something like "background-image: url('/imageproxy/https://static.qobuz.com/images/covers/../blah.jpg')". I'm not familiar with nginx, do you have enough to fix a mapping?

(real stuff copied from the web inspector:
background-image: url("/imageproxy/https%3A%2F%2Fstatic.qobuz.com%2Fimages%2Fcovers%2F1a%2Flt%2Fsxro2svy7lt1a_600.jpg/image_1024x1024_f.jpg");** box-shadow: inset 0 0 120vw 120vh var(--background-shadow-color);)

pssc commented 2 years ago

Thanks @jm38410 looks like a more general rule here would be more useful around 'url("/imageproxy/'.

pssc commented 2 years ago

@jm38410 are you willing to test an pre release will involve a bit of faf uninstalling and reinstalling and then back again?

jm38410 commented 2 years ago

Sure

Le 24 oct. 2021 à 21:26, Phill (pssc) @.***> a écrit :

 @jm38410 are you willing to test an pre release will involve a bit of faf uninstalling and reinstalling and then back again?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.

pssc commented 2 years ago

@jm38410 what arch are you on? and I will start some images building

jm38410 commented 2 years ago

armv7, it’s a pi 3 I think

Le 24 oct. 2021 à 21:52, Phill (pssc) @.***> a écrit :

 @jm38410 what arch are you on? and I will start some images building

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.

jm38410 commented 2 years ago

@pssc Hi Phil, I could not check your changes. I downloaded your "next" branch with your fixes on my HA installation but for some reason the docker still starts with an image that does not contain your fixes and I could not build it from my installation...

pssc commented 2 years ago

This should be fixed in the current release