pssc / ha-addon-lms

Logitech Media Server Addon for Home Assistant
GNU General Public License v3.0
55 stars 13 forks source link

Unable to pass get variable in url #70

Open ronluna opened 6 months ago

ronluna commented 6 months ago

Seems like entering player's mac address and or forcing a theme color in the url is getting completely ignored and simply load the initial page and not the player or theme specified in the url. any ideas ?

https://ha_server:8123/hassio/ingress/gs57c884_lms/?player=3c:d4:3c:ee:ea:5c&theme=dark

This works fine when not using ingress as:

http://ha_server:9000/?player=3c:d4:3c:ee:ea:5c&theme=dark

any ideas?

pssc commented 5 months ago

@ronluna its in the query string? I don't touch that. Its not something I have tired but I only support the default and material themes through ingress each theme requires custom rewrite rules for the ingress interface, which I have supplied at need to be turned on in the addon config for a specific theme.

ronluna commented 5 months ago

It's for both. default and material theme. I only use those two... it simply allows to force the material's theme and also forces the specified player when the mac address is in the url string. This come very handy when wanting to interact directly with a specific player once the HA user is at a specific area/room. Would be great to get it this working with ingress.

you can see the list of different querystrings supported by the material theme here:

https://github.com/CDrummond/lms-material/wiki/13-URL-query-parameters

pssc commented 5 months ago

As said ingress needs different rules for different themes, there is no facility to change this on the fly per client through ingress.

pssc commented 5 months ago

@ronluna the penny dropped on what your trying to do when debugging another issue in the material skin, your using the theme selection in the material skin?

ronluna commented 5 months ago

Not quite sure if I get the question above. theme selection as if the "Material" Skin was chose under the interface tab in LMS settings and I'm the ?theme=(light|dark) querystring as an argument ? If that's what the question meant.. then yes!

pssc commented 2 months ago

In theory this should now work, there is nothing I can see now preventing it

pssc commented 2 months ago

After some testing this still doesn't work