psss / did

What did you do last week, month, year?
https://did.readthedocs.io/
GNU General Public License v2.0
247 stars 105 forks source link

Add search for approved merge requests in gitlab module #241

Closed ukulekek closed 3 years ago

ukulekek commented 3 years ago

Hello! I would like to propose a small enhancement for the GitLab plugin. I daily review the patches on GitLab and I would like to see it in my status report. The pull request adds a search for approved merge requests on GitLab.
The output looks next:

* Merge requests approved on gitlab: 7
    * testing-farm/artemis#431 - Bumping mypy to newer version, 0.730
    * testing-farm/artemis#429 - Replace uses of `Query` with `SafeQuery` in...
    * testing-farm/artemis#428 - Converts resource IDs container used by...
    * testing-farm/artemis#427 - Adds task to run post-install script when...
    * testing-farm/artemis#426 - Adds helpers for work with remote content...
    * testing-farm/artemis#395 - Changes return value of `drivers...
    * testing-farm/artemis#425 - Moves context code into a separate module

I have tested it in a virtual environment on my laptop manually. I have failed to run pytest, because IIUIC did.tester user hasn't done such action in the past. Could you suggest to me how can I work around this? I have an idea to mock the search function somehow so it will return some dummy data, but it seems not consistent in comparison to other tests to me.

psss commented 3 years ago

Thanks for the improvement! I've created and new merge request and did tester approved it just a few minutes ago:

Could you adjust the test suite so that it verifies this approval?

ukulekek commented 3 years ago

@psss thanks! Test passed on my side.