search

psss / did

What did you do last week, month, year?
https://did.readthedocs.io/
GNU General Public License v2.0
246 stars 104 forks source link

Update packit config to address recent changes #284

Closed psss closed 1 year ago

psss commented 1 year ago

The srpm_build_deps section is now mandatory. The copr build should be specified explicitly.

kwk commented 1 year ago

I think this is more than what is actually needed. The minimal change to fix the Copr issue is here: https://github.com/psss/did/pull/285

psss commented 1 year ago

Thanks! It seems we've created the pull requests at the very same minute :) Actually there were some more adjustments which should be done for the packit configuration (copr build detection from testing jobs will be removed in the future), so I've included them all here. The python3-docutils requirement, however, seems to be unnecessary. Will remove it.

lukaszachy commented 1 year ago

Thanks! It seems we've created the pull requests at the very same minute :) Actually there were some more adjustments which should be done for the packit configuration (copr build detection from testing jobs will be removed in the future), so I've included them all here. The python3-docutils requirement, however, seems to be unnecessary. Will remove it.

Are you sure? SRPM cannot be built without python3-docutils (it is used during make srpm call) . Depends on what is installed by default however on reasonably minimal installs it was missing.

psss commented 1 year ago

Are you sure? SRPM cannot be built without python3-docutils...

Yes, that was my impression as well. And I remember adding this one to the config when setting up tmt. But, apparently, the build in #285 succesed. Ha! But the man page was not created correctly:

:: [ 10:16:33 ] :: [   FAIL   ] :: File 'man' should contain 'What did you do last week, month, year?'

So I'll keep it there.

kwk commented 1 year ago

LGTM