search

psss / did

What did you do last week, month, year?
https://did.readthedocs.io/
GNU General Public License v2.0
246 stars 104 forks source link

Fix error when building SRPM in copr #285

Closed kwk closed 1 year ago

kwk commented 1 year ago

This PR should fix this error:

packit.exceptions.PackitSRPMException: Preparation of the repository for creation of an SRPM failed: [Errno 2] No such file or directory: 'make'

Read more about the change here and why it only is required since January 2023: https://packit.dev/docs/configuration/#srpm_build_deps

kwk commented 1 year ago

Copr now works, but the tmt tests fail with:

::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::
::   man
::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::

:: [ 10:16:33 ] :: [  BEGIN   ] :: Check man page :: actually running 'man did | tee man'
:: [ 10:16:33 ] :: [   PASS   ] :: Check man page (Expected 0, got 0)
:: [ 10:16:33 ] :: [   FAIL   ] :: File 'man' should contain 'What did you do last week, month, year?' 
::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::
::   Duration: 0s
::   Assertions: 1 good, 1 bad
::   RESULT: FAIL (man)
psss commented 1 year ago

This seems to be a duplicate of #284, let's cover the necessary packit config changes there.

psss commented 1 year ago

Copr now works, but the tmt tests fail with:

Yes, that's caused by the missing python3-docutils which are used for generating the man page.

kwk commented 1 year ago

Closing in favor of #284