search

psss / did

What did you do last week, month, year?
https://did.readthedocs.io/
GNU General Public License v2.0
246 stars 104 forks source link

Report tasks commented properly in the gitlab plugin #308

Closed Kuba314 closed 1 year ago

Kuba314 commented 1 year ago

Events for issues commented also return tasks (work items) commented,
but gitlab's issues API endpoint doesn't return those and their own API
endpoint doesn't exist yet.

This means that the task iid can't be fetched in any way. Using
"unknown" instead of the iid makes sense as a workaround for now.

Tested by successfully getting namespace/project#unknown - Task title to show up in the report.

Resolves #307

P.S.: Please let me know if there are any design guidelines I missed or if I should squash the 2 commits.

psss commented 1 year ago

Please let me know if there are any design guidelines I missed or if I should squash the 2 commits.

Could you please just remove the gitlab: prefix from the commit messages to align with the recommendations? You can also squash the two commits covering the commented issue problem. Otherwise everything is just fine. Thanks.

psss commented 1 year ago

Plus, pre-commit is a bit unhappy about the long comment line. But that's it :)

Kuba314 commented 1 year ago

Removed the gitlab: prefix, squashed the commits and fixed the comment pre-commit was complaining about.