search

psss / did

What did you do last week, month, year?
https://did.readthedocs.io/
GNU General Public License v2.0
245 stars 103 forks source link

fix dockerfile executable path, add git to container #354

Open thehowl opened 5 months ago

thehowl commented 5 months ago

The path seems out of date. I'm not knowledgeable in setuptools (or python at all for that matter, I had already tried using did a while ago but I had enough of it after 5 minutes due to the usual virtualenv mess) so maybe it's supposed to actually install in /usr/bin but isn't.

I've also added git to make the extension work within docker. safe.directory set to * allows git to get the logs in directories in which the user is not an owner (likely the case for docker).

Side note: I also changed the docker run command I personally use. I don't think --privileged is actually needed. I haven't changed the docs in this PR, I don't know if there are use cases where it does make sense. For reference, this is what I use: I also added a new volume for the repository I want to track using git.

docker run --rm -it -v /home/howl/.config/did:/did.conf -v /home/howl/oc/gno:/gno howl/did

Suggestion: may be a good idea to use a custom entrypoint script that can parse $1 values like bash / sh and execute the commands accordingly, useful when debugging the container itself. Personally I just switched back and forth from ENTRYPOINT to CMD so I could test it out doing did bash.

lukaszachy commented 5 months ago

Suggestion: may be a good idea to use a custom entrypoint script that can parse $1 values like bash / sh and execute the commands accordingly, useful when debugging the container itself. Personally I just switched back and forth from ENTRYPOINT to CMD so I could test it out doing did bash

Isn't using podman run --entrypoint enough?

thehowl commented 5 months ago

Isn't using podman run --entrypoint enough?

Fair point, didn't know the flag