public_inbox: Fix email threads without an available root message

psss / did

What did you do last week, month, year?

https://did.readthedocs.io/

GNU General Public License v2.0

247 stars 105 forks source link

public_inbox: Fix email threads without an available root message #369

Open mripard opened 2 months ago

mripard commented 2 months ago

Hi,

@stefano-garzarella and @javierm have been reporting on the public-inbox plugin https://github.com/psss/did/pull/329 that they were having crashes.

It turns out that lore doesn't always manage to archive all the messages and we might find emails with a valid in-reply-to header, but can't retrieve the message from the ML archive.

This was partly due to an improper type annotation, so this PR fixes both the type annotations and the actual bug they were both facing.

stefano-garzarella commented 2 months ago

Thanks! Tested with my setup and this PR fixes the issue!

javierm commented 2 months ago

Hi, @mripard :smile:.

I'm afraid I haven't reported anything; don't even know this project :thinking:. Wrong username, maybe?

mripard commented 2 months ago

Yeah, sorry, I meant @martinezjavier