search

psss / did

What did you do last week, month, year?
https://did.readthedocs.io/
GNU General Public License v2.0
248 stars 107 forks source link

BUG: --github-pull-requests-closed doesn't seem to work #371

Open bsipocz opened 1 month ago

bsipocz commented 1 month ago

--github-pull-requests-closed returns empty, even though I had my own PRs closed/merged as well as closed/merged other people's PRs both this week and last.

bsipocz commented 1 month ago

Ahh, OK, I see that it assumes that a PR was assigned to someone. However, that is a very strong workflow assumption, and it's not at all how any of the community libraries work in the scientific python ecosystem.

So, now I rephrase and ask for either some documentation clarification, e.g. mentioned 'assigned' in Pull requests closed on github; or have another category for PRs where either the PR or any of its commits are authored by the login person, or have another category where a PR is closed by the login person.