search

pst-format / libpst

library for reading Microsoft Outlook PST files
GNU General Public License v2.0
16 stars 4 forks source link

Use toplevel 'mode' to decide whether to generate separator #3 #4

Closed brychcy closed 2 years ago

brychcy commented 2 years ago

fixes #3

pabs3 commented 2 years ago

The patch looks good, but there are a couple of changes needed:

The patch changes the name of the mode variable in the definition of write_normal_email but the declaration of write_normal_email earlier in readpst.c hasn't been changed. Please change both of them.

Please change the commit message to this:

Use global mode to decide whether to generate separator

This fixes the mbox output for nested PST messages.

Also fixes shadowing the global mode variable.

Fixes: https://github.com/pst-format/libpst/issues/3

-- bye, pabs

https://bonedaddy.net/pabs3/

pabs3 commented 2 years ago

I've rebased and merged the patch, thanks for your contributions.