search

pstadler / flightplan

Run sequences of shell commands against local and remote hosts.
https://www.npmjs.com/package/flightplan
MIT License
1.82k stars 116 forks source link

Rsync with unicode filenames #102

Closed Znarkus closed 9 years ago

Znarkus commented 9 years ago

With unicode filenames, the path is returned as "path/to/file\302.md" instead of path/to/file.md. Note the ".

This creates this rsync problem:

localhost > rsync: link_stat "/some/path/"path/to/file\302.md"" failed: No such file or directory (2)

Checked the tmpFile that is created by Shell.prototype.transfer and " are present on lines with unicode paths.

$ fly --version
0.6.4
$ rsync --version
rsync  version 2.6.9  protocol version 29
pstadler commented 9 years ago

The question is if this is a bug in rsync itself. Please provide some context, how you pass this file to rsync.

Znarkus commented 9 years ago

This is the command that is executed where the file is passed to rsync:

https://github.com/pstadler/flightplan/blob/627feccc7680cecf12b512513acbc0d12ca14f3c/lib/transport/shell.js#L110

pstadler commented 9 years ago

That's not really helpful. I need to know what you're passing with the files parameter.

pstadler commented 9 years ago

Is this still a problem? If so, please provide further information.