search

pstanoev / simple-svelte-autocomplete

Simple Autocomplete / typeahead component for Svelte
http://simple-svelte-autocomplete.surge.sh/
MIT License
464 stars 78 forks source link

Esc does not propagate #106

Closed Prinzhorn closed 2 years ago

Prinzhorn commented 3 years ago

Do you remember why you added this in the first commit https://github.com/pstanoev/simple-svelte-autocomplete/blame/master/src/SimpleAutocomplete.svelte#L738 ? I'm relying on events bubbling up.

pstanoev commented 3 years ago

Not sure... Do you have some idea what would be the consequence if that is removed?

Prinzhorn commented 3 years ago

Do you have some idea what would be the consequence if that is removed?

In contrast to preventDefault this only affects other listeners for the same event and none of the browser stuff. And you only have a single on:keydown, so it won't make any difference. It shouldn't affect on:keypress at all either.

pstanoev commented 3 years ago

Okay, I'll remove it in the next version.

pstanoev commented 2 years ago

Removed in version 2.2.4.