search

pstanoev / simple-svelte-autocomplete

Simple Autocomplete / typeahead component for Svelte
http://simple-svelte-autocomplete.surge.sh/
MIT License
464 stars 78 forks source link

Keep menu closed when locked #197

Closed azmeuk closed 1 year ago

azmeuk commented 1 year ago

Without this patch, when locked is true, users can open the menu but cannot select items. This feels a very strange UX to me. Instead I suggest that the menu stays closed until users hit the clear button, and the menu would open automatically at this moment.

Alternatively, we could deselect the item when the input is clicked.

github-actions[bot] commented 1 year ago

Coverage report

St.:grey_question:
 Category Percentage Covered / Total
🔴 Statements
59.79% (+0.3% 🔼)
 284/475
🟡 Branches
68.27% (+0.12% 🔼)
 185/271
🔴 Functions 33.33% 6/18
🔴 Lines
59.72% (+0.23% 🔼)
 258/432

Test suite run success

16 tests passing in 4 suites.

Report generated by 🧪jest coverage report action from cc204f1f220e6e95727f93114eb31f06f2da9846

pstanoev commented 1 year ago

part of v.2.5.2.