search

psteiger / flow-lifecycle-observer

A plugin for collecting Kotlin Flow in an Android Lifecycle-aware manner.
MIT License
57 stars 7 forks source link

Add launchWhenX variants, and deprecated former API #3

Closed p-lr closed 3 years ago

p-lr commented 3 years ago

Hi @psteiger ,

Here are the changes we discussed a few days ago. In addition to what was initially planned, I also did the following:

After that, you'll have to update the Readme at your convenience.

psteiger commented 3 years ago

Hi @peterLaurence ,

Deprecated the former APIs and modified them so they are aliases for collectWhenStarted

Good!

Modified build.gradle to use the latest release version of gradle plugin Had to touch some files in .idea folder to use java 8 instead of 11. Why have you pushed those files?

Latest Gradle versions, 4.2.0-alpha*, for Android Studio 4.2 Canary, which I use, requires Java 11 for building, even though latest Android runtime is Java 8. I have no problem reverting back to the stable versions, though.

For library publication matter, I'm unsure about the need for those files to be published in GitHub, I will read more on this.

Updated Kotlin

Good!

After that, you'll have to update the Readme at your convenience.

Ok.

Thank you for your contribution!

p-lr commented 3 years ago

Thanks!

For library publication matter, I'm unsure about the need for those files to be published in GitHub, I will read more on this.

I believe you can remove them since they aren't necessary to compile the project. They contain settings which are specific to your configuration. The only constraint you enforce (and I do the same for the library I maintain) is that this project uses Java 8 langage features - in the build.gradle. I'm not sure which version of Java was used by Jitpack. But we should be able to build this library using Java 8.