pstoica / pow-viz

MIT License
2 stars 1 forks source link

Trends Chart #4

Open pstoica opened 10 years ago

pstoica commented 10 years ago

Maybe try to make this line up with the months in the calendar view?

camreon commented 10 years ago

will try to update the design of this chart before class. it's filling in under the line for some reason and looks rough. might have time to add chart for #2 also

pstoica commented 10 years ago

think you're missing some css (stylesheets/main.less), looked at http://bl.ocks.org/mbostock/3883245

.line {
  fill: none;
  stroke: steelblue;
  stroke-width: 1.5px;
}
pstoica commented 10 years ago

pretty sure we should combine the charts into one. even though trends is on a different scale (we can rescale it), it's merely a suggestion instead of hard data so i think it should work out.

camreon commented 10 years ago

yeah, it was missing that. sounds good. i want to add horizontal grid lines too

pstoica commented 10 years ago

@camreon the price history shows up now. some to-do for the charts

I'll work on the linking, and maybe tooltips for the maps and the charts?

pstoica commented 10 years ago

also, the price chart doesn't reflect null values right now since there are no entries for those months. should we do null values, or let it bridge the gap?

camreon commented 10 years ago

working on showing a popup of data when you mouse over the chart now and then cleaning up the rest of the chart.

i can't figure out why the trend data is going out of the chart's bounds. do either of you want to look into that more?

and i think it's fine to let it bridge gap months for now

pstoica commented 10 years ago

takin a look

pstoica commented 10 years ago

fixed, it was still drawing dates before 2010, so i filtered that on the server side.

pstoica commented 10 years ago

I just added caching for all the JSON responses.

pstoica commented 10 years ago

fyi, the mongo mapreduce was kind of wrong. you should see more data now, actually.

camreon commented 10 years ago

@pstoica why are you keeping track of all the past queried prices in line 331?

prices = $.merge(prices, json.prices);
pstoica commented 10 years ago

I threw it Ito a global I think so I could use it for the popups on the map?

pstoica commented 10 years ago

*threw it into

pstoica commented 10 years ago

@camreon that code was actually meant to fill the prices with null values (so that there are visible gaps) and replace them with whatever isn't null. or do you want to leave it as continuous? i feel like we should show gaps so we don't mislead the user or whatever.

camreon commented 10 years ago

ah k. i agree, showing gaps is more honest. i was just being lazy before lol